fix(ha): send target as a sibling of service_data in websocket call_service

[springfall2008]

Summary

• HA's call_service websocket command expects target (entity_id/device_id/area_id addressing) as a sibling of service_data, not nested inside it. Predbat's call_service_template()/call_service() forwarded any key from a dict-style service definition verbatim into service_data, so a service configured with the common target: entity_id: ... syntax (matching standard HA action/automation syntax, and easy to reach for when wiring up a generic input_boolean Service API bridge) ended up with target nested inside service_data.
• HA rejects that shape with invalid_format: extra keys not allowed @ data['target'], which silently blocked every charge/discharge/freeze service call while Predbat's internal plan and predbat.status kept reporting normally, since the failure is only logged as a Warn: and never propagated back to plan/status state.
• Fix: in socketLoop()'s queued-command send, pop target out of service_data and send it as its own top-level field in the outgoing call_service frame.
• Documented the target: addressing form as supported alongside the existing flat entity_id: form in has_service_api.

Fixes #4662

Test plan

• New regression test test_hainterface_socketloop_call_service_target_field drives a real socketLoop() iteration with a queued input_boolean.turn_on command carrying a nested target, and asserts the frame sent over the websocket has target as a sibling field, not nested inside service_data. Confirmed RED before the fix, GREEN after.
• ./run_all --test hainterface_service --test hainterface_websocket --test hainterface_lifecycle --test hainterface_state --test hainterface_api --test inverter — all pass.
• ./run_all --quick — 155 passed, identical to a clean main checkout (one pre-existing, order-dependent test_web_functions.py crash reproduces identically on unmodified main, unrelated to this change).
• pre-commit run --all-files (ruff, black, cspell, markdownlint, etc.) — all pass.

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

The current implementation mutates the queued service_data dict in-place (affecting cross-thread state/logging), and the new documentation sentence is misleading about how non-target fields are sent.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Fixes Home Assistant WebSocket call_service framing so that target (entity/device/area addressing) is sent as a top-level sibling of service_data, matching HA’s expected schema and unblocking service-based inverter control flows (notably input_boolean bridge automations).

Changes:

• Update HAInterface.socketLoop() to extract target from queued service_data and send it as the top-level target field in the outgoing call_service frame.
• Add a regression test asserting the outbound WebSocket frame shape for queued commands containing a nested target.
• Document the supported target: form in the service API configuration docs.

File summaries

File	Description
apps/predbat/ha.py	Adjusts WebSocket call_service payload construction to place target at the correct top-level location.
apps/predbat/tests/test_hainterface_websocket.py	Adds a regression test to verify correct target framing in queued WebSocket service calls.
docs/inverter-setup.md	Documents target: syntax support for service API definitions.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.