Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebAsyncTask<V>is a supported Spring MVC async return type, but springdoc does not treat it as a response wrapper. The generated response schema is a$refto aWebAsyncTaskcomponent schema instead ofV.Callable,DeferredResultandFutureare already registered inSpringDocConfiguration.WebAsyncTaskis the one that is missing, so this adds it.For a controller returning
WebAsyncTask<String>, the response schema is now{"type": "string"}and noWebAsyncTaskschema is emitted incomponents.Verification: the new app273 tests (v30 and v31) fail on master with
Unexpected: $refand pass with the change.mvn testis green for springdoc-openapi-starter-common (55), springdoc-openapi-starter-webmvc-api (655) and springdoc-openapi-starter-webflux-api (136).