fix(text): keep Spotify 1.3 playback timestamps aligned - #18
Closed
afonsojramos wants to merge 1 commit into
Closed
afonsojramos wants to merge 1 commit into
afonsojramos wants to merge 1 commit into
Conversation
Member
Author
|
Superseded by #17, already merged and published as text@0.1.6. That release includes the timestamp fix and an additional seek-handle alignment correction. The companion Spotify 1.3 classmap fix continues in spicetify/classmaps#8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text keeps the playback timestamps readable on Spotify 1.3 after the playback-bar classmap hooks are restored. Spotify now absolutely positions the inner timestamp spans, which collapses Text's elapsed label and overlaps its slash separator. Both timestamps now remain in normal flow.
Coordinate release with the companion classmap change. Publish this Text update before the classmap correction so users receive the timestamp fix before the restored selectors take effect.
Validation: 729 module tests passed, with 34 skips. On macOS Spotify 1.3.0.277, the combined changes restored the full-width 16px seek track; pointer seeking, ArrowRight seeking, and the duration/remaining-time toggle passed. The final Text and unthemed visual suite ran twice with 14 pixel-identical states and verified cleanup. The worktree CSS was loaded through the local module installer; the published Store update path has not been exercised.