Skip to content

fix(rust): make Windows release test sockets blocking - #3954

Merged
afonsojramos merged 1 commit into
v3-betafrom
fix/windows-release-fixture
Sep 17, 2026
Merged

afonsojramos merged 1 commit into
v3-betafrom
fix/windows-release-fixture

Conversation

@afonsojramos

Copy link
Copy Markdown
Member

Windows release tests intermittently fail with WouldBlock when the classmap HTTP fixture accepts a connection before its request arrives. The accepted socket inherits the listener's nonblocking mode on Windows; explicitly make it blocking before setting the existing five-second read timeout.

This changes only the test fixture and bumps the workspace to beta.19. Beta.18 already has Linux and macOS assets, so its published tag stays intact and beta.19 will provide a complete release for all platforms.

Validation: all three compatibility-refresh tests pass locally; formatting passes. Correctness and testing review found no issues. Windows CI must pass before merge.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2cf379f0-78bf-4de0-83c1-06b63108424b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@afonsojramos
afonsojramos merged commit b50800b into v3-beta Sep 17, 2026
5 checks passed
@afonsojramos
afonsojramos deleted the fix/windows-release-fixture branch September 17, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant