fix(v3): restore GraphQL definitions and macOS app handoff - #3951
Merged
Merged
Conversation
Read persisted operation metadata from captured factories without executing them. Preserve the v2 registry and omit ambiguous definitions in v3. Fixes #3927
Verify the final applet signature before registering it with Launch Services.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore GraphQL operation definitions for modules on the captured v3 client and repair macOS app-link registration.
GraphQL definitions are discovered from captured webpack factories without executing those factories. Late-loaded definitions refresh on property lookup and enumeration, ambiguous entries are omitted, and the existing v2 registry is preserved. The macOS protocol applet is now signed and verified after its URL-scheme metadata is written.
Validation: 157 JavaScript tests, payload and wrapper checks, targeted lint/format, and four macOS platform tests including actual osacompile and codesign execution pass.
Live macOS verification passed on Spotify 1.3.0.277: 95 GraphQL definitions were discovered and getAlbum returned album data. The registered applet passed strict signature verification; the normal macOS URL handoff completed Apply and restarted Spotify. This used a combined local build with #3948 and #3952, not a published release. Browser custom-scheme prompts were not exercised.
Fixes #3927