Fix: Update conditional statement for COG inheritance to allow DwC Archive update - #8413
Conversation
|
Warning One or more dependencies are approaching or past End-of-Life. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesThe inheritance query processor now normalizes requested field names to lowercase. Processing continues only for table Inheritance query processing
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@specifyweb/backend/inheritance/api.py`:
- Line 44: Use one canonical spelling for the catalog-number field in the
inheritance check and the subsequent .index lookup: update the logic around
first_field_names and its lookup so both use the repository’s normalized
field-name convention, allowing valid CollectionObject requests to proceed with
inheritance processing.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 02467e56-8190-4e86-a3d2-3ebfb48de9df
📒 Files selected for processing (1)
specifyweb/backend/inheritance/api.py
emenslin
left a comment
There was a problem hiding this comment.
- Verify it works
Looks good, can export DwcA without error
Fixes #8411
Checklist
self-explanatory (or properly documented)
specify7/specifyweb/specify/management/commands/run_key_migration_functions.py
Line 50 in ea04665
Testing instructions
Summary by CodeRabbit