Wait for WebAssembly setup before writing SPZ - #448
Open
oscarlorentzon wants to merge 1 commit into
Open
oscarlorentzon wants to merge 1 commit into
oscarlorentzon wants to merge 1 commit into
Conversation
Writing SPZ never waited for the WebAssembly module, so a call made before loading finished threw a type error. Writing now waits for the module and returns a promise callers must await.
Collaborator
Author
|
As mentioned above, this breaks the Is it acceptable to break compatibility here if we treat the change as fixing a defect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeSpzcalled into the WebAssembly module without awaiting the instantiation that starts when Spark is imported, so a call made before instantiation finished threwTypeError: Cannot read properties of undefined (reading 'packedsplats_to_gsplatarray'). Awaiting instantiation makeswriteSpzasync, so both overloads return a promise and every caller has to await the result, a break in the signature added in 2.2.0.transcodeSpzadded an equivalent await in #438.