Identify Three.js types with instanceof - #446
Merged
dmarcos merged 1 commit intoSep 21, 2026
Merged
Conversation
Two texture checks read the boolean marker Three.js sets on its own objects while every other check uses instanceof. Both now use instanceof, and a comment says why the XR render target check keeps the marker.
mrxz
approved these changes
Sep 21, 2026
Contributor
|
Sweet! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #443.
Three.js types were identified two ways,
instanceofin 20 places and theisTexturemarker in two. The library now usesinstanceofthroughout, apart from the XR render target check, where a comment says why.