Update TypeScript and Vite, use Vitest for tests - #445
Merged
Merged
Conversation
oscarlorentzon
approved these changes
Sep 21, 2026
oscarlorentzon
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall, and Vitest is a reasonable choice with Vite already in use.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates several of the
devDependencies, mainly motivated by the goal of updating TypeScript, where the other changes followed naturally:vite-plugin-glslneeded for Vite 7+ supportvite-plugin-dtscan be made to work, but effectively requires including TS 6.X as well, instead replaced with native tscts-nodedoes not work with TypeScript 7.0.2 (ts-node doesn't work with Typescript 7.0.2 TypeStrong/ts-node#2174), replaced with Vitest for unit testsRemoving
vite-plugin-dtshas several benefits, as it turns out this was a good chunk of the build time (~90%), additionally it was performed for both dev and production builds. The output oftscis near identical, only differing in things like used quotes and order of properties/types (see mrxz@5383545).Adding Vitest to replace the
ts-nodebased "test runner" is up for debate. I do think a proper testing framework makes sense over raw node asserts, but it doesn't have to be Vitest. Given Vite is already used though, it is a natural choice IMHO.