chore: Remove deprecated src teams commands - #1376
Open
marcleblanc2 wants to merge 2 commits into
Open
Conversation
Teams were removed in Sourcegraph 7.0. Since #1257 (src-cli 7.0.0) the command has refused to run against 7.x instances, so it only works against instances that are no longer supported. Remove it and its reference page. Drops the "teams.md" entry from the doc golden list and the legacyGroupsWithoutSubcommandPages exemption added in #1375, so every remaining legacy group is now expanded into subcommand pages. Part of https://linear.app/sourcegraph/issue/FE-502 Amp-Thread-ID: https://ampcode.com/threads/T-01a08410-86ca-72be-9928-2810e837fae1 Co-authored-by: Amp <amp@ampcode.com>
This was referenced Sep 9, 2026
…ntries Sourcegraph70 was only used by the teams version gate. The `extensions` and `gateway` commands were removed in #1173 and earlier but were still listed in `src help`. Part of https://linear.app/sourcegraph/issue/FE-502 Amp-Thread-ID: https://ampcode.com/threads/T-01a08410-86ca-72be-9928-2810e837fae1 Co-authored-by: Amp <amp@ampcode.com>
src teams commandssrc teams commands
src teams commandssrc teams commands
marcleblanc2
added a commit
to sourcegraph/docs
that referenced
this pull request
Sep 11, 2026
Part of [FE-502](https://linear.app/sourcegraph/issue/FE-502). **Step 4 of 4** in a cross-repo stack, but **mergeable now** — it pre-seeds what the generated-docs sync will eventually write, so the live reference gets fixed without waiting on a src-cli release. ## Why The `src` CLI reference is generated by `src doc` and synced here by sourcegraph/sourcegraph's `sync/generated-docs` job. Two generator bugs (fixed in sourcegraph/src-cli#1375) left this reference incomplete: - `search-jobs`, `debug` and `snapshot` were never registered in the generator's `commanders` map, so each is a single page with only the group help; their 16 subcommands have no reference pages. (The 8 `search-jobs/*.mdx` pages here were hand-written by Travis Lyons in May 2025 to paper over this; nothing links to them.) - `index.mdx` lists only the 8 urfave/cli commands (`abc`, `api`, `auth`, `codeowners`, `login`, `orgs`, `users`, `version`) — `batch`, `repos`, `search`, `config`, etc. are missing from https://sourcegraph.com/docs/cli/references today. ## What - `index.mdx`: lists all 19 top-level commands. - `debug/{index,compose,kube,server}.mdx`, `snapshot/{index,databases,restore,summary,test,upload}.mdx`: new. - `search-jobs/index.mdx`: new; `search-jobs/{cancel,create,delete,get,list,logs,restart,results}.mdx`: hand-written pages replaced by generated ones (same usage text, plus a flags table; the `<p className="subtitle">` blurbs go away since the generator doesn't emit them). - Deleted `debug.mdx`, `search-jobs.mdx`, `snapshot.mdx`. - Deleted `teams.mdx` and dropped `teams` from `index.mdx`: teams were removed in Sourcegraph 7.0 and sourcegraph/src-cli#1376 removes the command, so the generator no longer emits this page. No redirect (same call as #1886). The sync job never deletes files, and in contentlayer routing a flat `foo.mdx` shadows `foo/index.mdx` (the same bug #1886 fixed for `auth.mdx`/`codeowners.mdx`), so these have to go by hand for the new index pages to be reachable. Content was produced by running the patched generator (src-cli `main` + #1375) and the same `tools/md2mdx` conversion the sync uses, so the sync PR that follows sourcegraph/sourcegraph#15528 should be a no-op for these paths. No redirects: the three deleted URLs (`/cli/references/{debug,search-jobs,snapshot}`) keep resolving, now to the new index pages. ## Stack 1. sourcegraph/src-cli#1375 — generator fix + tests; sourcegraph/src-cli#1376 (stacked) — remove `src teams`; sourcegraph/src-cli#1377 (stacked) — `src help` generated from registered commands, tests help == docs 2. src-cli 7.7.0 release (none since 7.6.0; blocks 3) 3. sourcegraph/sourcegraph#15528 — pin bump + `OUTPUT_FILES` + regenerate (draft until 2) 4. **this PR** 5. sourcegraph/sourcegraph#15529 — make the docs sync mirror `docs/cli/references/` so removed commands disappear automatically (merge after 3 and this PR) Related: #1886 (removed 28 stale pages for commands that no longer exist). ## Test plan `npx contentlayer build` → 528 documents; routes resolve to the intended files: ``` /cli/references/debug <- cli/references/debug/index.mdx /cli/references/search-jobs <- cli/references/search-jobs/index.mdx /cli/references/snapshot <- cli/references/snapshot/index.mdx ``` plus the 16 subcommand routes. (The `ERR_INVALID_ARG_TYPE`/clipanion stack trace during the build is pre-existing on `main`.) ## Amp threads - [Stale command docs](https://ampcode.com/threads/T-01a08410-86ca-72be-9928-2810e837fae1) --------- Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of FE-502. #1377 is stacked on this. Stacked on #1375 (base branch is
fix/doc-legacy-groups; retarget tomainonce #1375 merges — the diff shown is only this PR's commit).Why
Teams were removed in Sourcegraph 7.0. #1257 (shipped in src-cli 7.0.0, 2026-02-25) made
src teamsrefuse to run against 7.x instances (checkTeamsAvailability: "the 'src teams' commands are not available for Sourcegraph versions 7.0 and later ... Teams have been removed"). Six months later the command only works against instances that are no longer supported, yet it still appears insrc helpand has a reference page on https://sourcegraph.com/docs/cli/references/teams.While fixing
src docin #1375 I had to special-caseteamsso the generator wouldn't expand it into 9 new pages for a removed feature. Removing the command is the cleaner answer.What
Delete
cmd/src/teams*.goandcmd/src/team_members_list.go(9 files,teamsCommands+teamMembersCommands, theteamalias,checkTeamsAvailability).Drop the
teams,team manages teamsline from thesrcusage text inmain.go.doc_test.go: removeteams.mdfromexpectedDocFiles;legacyGroupsWithoutSubcommandPagesis now empty, so every remaining legacy group is expanded into subcommand pages.CHANGELOG entry under Unreleased → Removed.
Remove the
Sourcegraph70feature flag frominternal/features/features.go; the teams gate was its only user.Also drop
extensions,extandgatewayfrom thesrcusage text — those commands were removed long ago (chore: Remove deprecated extensions commands #1173 etc.) but were still listed.Downstream
The generated
teams.mddisappears fromsrc docoutput, so after the next release:"teams.md"removed fromOUTPUT_FILESanddoc/cli/references/teams.mddeleted (I'll update that PR).docs/cli/references/teams.mdx(the sync never deletes) — done in docs/cli: Add missing doc pages for src-cli commands docs#1889.Test plan
rg -i '\bteams?\b' cmd internalfinds no remaining references outside search test fixtures (where "team" is repository content).rg 'Sourcegraph70|extensions|gateway' cmd internalis empty.src(no args) now lists only commands that exist.