fix/batches: discard extracted Git metadata before Git initialization - #1370
Merged
cbrnrd merged 1 commit intoSep 4, 2026
Conversation
cbrnrd
marked this pull request as ready for review
September 4, 2026 14:08
BolajiOlajide
approved these changes
Sep 4, 2026
cbrnrd
deleted the
carterbrainerd-vuln-146-i-can-turn-committed-backslash-filenames-into-host-git-hooks
branch
September 4, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The checks added in #1366 and #1367 do not cover every Windows filename alias. Names such as
.git./configand.git::$INDEX_ALLOCATION/configcan pass the archive check but still resolve to.git/configon disk.The first host-side
git addreads this repository-local configuration before the trusted Git metadata snapshot is created and before the container step starts. Configuration such ascore.fsmonitorcan therefore run a command on the host.Solution
Remove any
.gitmetadata created during archive extraction before runninggit init. Git then creates a fresh repository with trusted configuration. This avoids relying on a complete list of Windows filename aliases.Verification Evidence
core.fsmonitorconfiguration and verified that it does not run.go test ./internal/batches/...GOOS=windows GOARCH=amd64 go test -c ./internal/batches/workspace