spell check: link summary items to the source, shorten them, flag unsorted dictionary entries - #1917
Merged
Merged
Conversation
…orted dictionary entries - Summary comment: line and column link to the file in source view (?plain=1) with the word highlighted; each item is `word` → `first suggestion` instead of the whole line. - check-spelling.mjs reports entries added to cspell-allow-list.txt or cspell-block-list.txt out of alphabetical order (case- and accent-insensitive, like CSpell matches; comments and blank lines start a new run). Trailing '# comments' after a word are ignored, as CSpell does. - Drop the unused context field from the JSON findings. Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marcleblanc2
enabled auto-merge (squash)
September 11, 2026 11:20
…ted entry belongs on Amp-Thread-ID: https://ampcode.com/threads/T-01a08fee-74b4-76dc-aaf9-d1245d68fdc9 Co-authored-by: Amp <amp@ampcode.com>
jac
approved these changes
Sep 11, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from testing the PR checks on #1913 / #1914.
line N, column Mis a link to the file in source view (?plain=1) with the flagged word highlighted (#L152C6-L152C14). Each item is now`word` → `first suggestion`instead of the whole line.dev/check-spelling.mjsalso flags entries added tocspell-allow-list.txtorcspell-block-list.txtout of alphabetical order. Order is case- and accent-insensitive (Intl.Collator('en', {sensitivity: 'base'})), which is how CSpell matches and how both lists are already sorted (Côtebeforecrashloop); a blank line or# commentstarts a new run, so the sectioned top of the allow list is fine. Both lists pass as-is, so no re-sort in this PR.bazqux # why) are accepted by CSpell (everything from#is stripped) and by this check.contextfield from the findings JSON.Tested locally with cspell@10: misspellings plus out-of-order entries in both lists,
--format text/--format json, andpost-spelling-review.mjsagainst a stubbed GitHub API to render the summary and inline comments.