CSpell review: leave no orphaned review body once findings are fixed - #1903
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This comment has been minimized.
This comment has been minimized.
burmudar
approved these changes
Sep 11, 2026
Post the inline-comment review with an empty body, minimize the summary comment as resolved when findings reach zero (and unminimize when new ones appear), and move the 'up to N inline' note into the summary. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a08e26-0c39-723b-95ad-65455002f541
Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
cspell-tidy-resolved-comments
branch
from
September 11, 2026 09:27
5edacb8 to
6418a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the recurring CSpell comment mess seen on #1902: after typos are fixed, the review body that carried the inline comments is orphaned (the summary flips to ✅ and inline comments are deleted, but a submitted review cannot be deleted).
RESOLVEDwhen findings reach zero; unminimize if new findings appearTested end-to-end on throwaway PR #1904: with typos, a bodyless review carried the inline comments; after fixing them, the review vanished (no orphaned body) and the summary was minimized as resolved. This PR also flagged and then resolved its own
unminimizefinding, now in the allow list.Co-authored-by: Amp amp@ampcode.com