docs/cli: Remove doc pages for removed src-cli commands - #1886
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marcleblanc2
force-pushed
the
cli-refs/remove-stale-command-pages
branch
from
September 9, 2026 03:55
3032bf5 to
dd1683d
Compare
This was referenced Sep 9, 2026
marcleblanc2
added a commit
that referenced
this pull request
Sep 9, 2026
Teams were removed in Sourcegraph 7.0; src-cli#1376 removes the command. No redirect, per the same call as #1886. Part of https://linear.app/sourcegraph/issue/FE-502 Amp-Thread-ID: https://ampcode.com/threads/T-01a08410-86ca-72be-9928-2810e837fae1 Co-authored-by: Amp <amp@ampcode.com>
pjlast
approved these changes
Sep 11, 2026
marcleblanc2
enabled auto-merge (squash)
September 11, 2026 01:49
The docs sync from sourcegraph/sourcegraph (doc/_generated.push.sh) only copies generated pages into docs/cli/; it never deletes, so pages for commands removed from src-cli have lingered. Remove them. Removed from src-cli: - extensions/* (src-cli#1173), lsif (#1147), scout (#1196), sbom + signature (#1273), admin (#1309), validate (#1310) Never shipped: - prompts/* documented src-cli#1168, which was closed unmerged Stale duplicates shadowing generated pages: - auth.mdx and codeowners.mdx collide with auth/index.mdx and codeowners/index.mdx on the same route; contentlayer picked the stale flat files, hiding the generated group pages. Amp-Thread-ID: https://ampcode.com/threads/T-01a08410-86ca-72be-9928-2810e837fae1 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
cli-refs/remove-stale-command-pages
branch
from
September 11, 2026 02:03
dd1683d to
35b8dd1
Compare
marcleblanc2
added a commit
that referenced
this pull request
Sep 11, 2026
Teams were removed in Sourcegraph 7.0; src-cli#1376 removes the command. No redirect, per the same call as #1886. Part of https://linear.app/sourcegraph/issue/FE-502 Amp-Thread-ID: https://ampcode.com/threads/T-01a08410-86ca-72be-9928-2810e837fae1 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
added a commit
that referenced
this pull request
Sep 11, 2026
Part of [FE-502](https://linear.app/sourcegraph/issue/FE-502). **Step 4 of 4** in a cross-repo stack, but **mergeable now** — it pre-seeds what the generated-docs sync will eventually write, so the live reference gets fixed without waiting on a src-cli release. ## Why The `src` CLI reference is generated by `src doc` and synced here by sourcegraph/sourcegraph's `sync/generated-docs` job. Two generator bugs (fixed in sourcegraph/src-cli#1375) left this reference incomplete: - `search-jobs`, `debug` and `snapshot` were never registered in the generator's `commanders` map, so each is a single page with only the group help; their 16 subcommands have no reference pages. (The 8 `search-jobs/*.mdx` pages here were hand-written by Travis Lyons in May 2025 to paper over this; nothing links to them.) - `index.mdx` lists only the 8 urfave/cli commands (`abc`, `api`, `auth`, `codeowners`, `login`, `orgs`, `users`, `version`) — `batch`, `repos`, `search`, `config`, etc. are missing from https://sourcegraph.com/docs/cli/references today. ## What - `index.mdx`: lists all 19 top-level commands. - `debug/{index,compose,kube,server}.mdx`, `snapshot/{index,databases,restore,summary,test,upload}.mdx`: new. - `search-jobs/index.mdx`: new; `search-jobs/{cancel,create,delete,get,list,logs,restart,results}.mdx`: hand-written pages replaced by generated ones (same usage text, plus a flags table; the `<p className="subtitle">` blurbs go away since the generator doesn't emit them). - Deleted `debug.mdx`, `search-jobs.mdx`, `snapshot.mdx`. - Deleted `teams.mdx` and dropped `teams` from `index.mdx`: teams were removed in Sourcegraph 7.0 and sourcegraph/src-cli#1376 removes the command, so the generator no longer emits this page. No redirect (same call as #1886). The sync job never deletes files, and in contentlayer routing a flat `foo.mdx` shadows `foo/index.mdx` (the same bug #1886 fixed for `auth.mdx`/`codeowners.mdx`), so these have to go by hand for the new index pages to be reachable. Content was produced by running the patched generator (src-cli `main` + #1375) and the same `tools/md2mdx` conversion the sync uses, so the sync PR that follows sourcegraph/sourcegraph#15528 should be a no-op for these paths. No redirects: the three deleted URLs (`/cli/references/{debug,search-jobs,snapshot}`) keep resolving, now to the new index pages. ## Stack 1. sourcegraph/src-cli#1375 — generator fix + tests; sourcegraph/src-cli#1376 (stacked) — remove `src teams`; sourcegraph/src-cli#1377 (stacked) — `src help` generated from registered commands, tests help == docs 2. src-cli 7.7.0 release (none since 7.6.0; blocks 3) 3. sourcegraph/sourcegraph#15528 — pin bump + `OUTPUT_FILES` + regenerate (draft until 2) 4. **this PR** 5. sourcegraph/sourcegraph#15529 — make the docs sync mirror `docs/cli/references/` so removed commands disappear automatically (merge after 3 and this PR) Related: #1886 (removed 28 stale pages for commands that no longer exist). ## Test plan `npx contentlayer build` → 528 documents; routes resolve to the intended files: ``` /cli/references/debug <- cli/references/debug/index.mdx /cli/references/search-jobs <- cli/references/search-jobs/index.mdx /cli/references/snapshot <- cli/references/snapshot/index.mdx ``` plus the 16 subcommand routes. (The `ERR_INVALID_ARG_TYPE`/clipanion stack trace during the build is pre-existing on `main`.) ## Amp threads - [Stale command docs](https://ampcode.com/threads/T-01a08410-86ca-72be-9928-2810e837fae1) --------- Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The docs sync from
sourcegraph/sourcegraph(doc/_generated.push.sh) doescp -R -L doc/cli/** _clone/docs/cli/— it only adds and updates pages, never deletes. So when a command is removed from src-cli, its reference page lingers here forever. Replaying the sync againstmainshows zero drift in the 62 generated pages, but 36 files underdocs/cli/references/are never written by it.This PR deletes the 28 that are stale. No redirects are added; none of these pages are linked from anywhere in the site.
Removed (28 files)
Command removed from src-cli
extensions/{index,copy,delete,get,list,publish}lsifsrc code-intel upload)scoutsbom,signatureadminvalidateCommand never shipped
prompts+ 13 subcommand pages (#1155) documented sourcegraph/src-cli#1168, which was closed unmerged.Stale duplicates shadowing generated pages
auth.mdxandcodeowners.mdxcollide withauth/index.mdx/codeowners/index.mdx: contentlayer flattens both tocli/references/auth, andallPosts.findreturned the stale flat file. After this change/cli/references/authand/cli/references/codeownersrender the generated group pages (verified withcontentlayer build).Kept
search-jobs/{cancel,create,delete,get,list,logs,restart,results}— the subcommands exist, butsrc doconly emits a singlesearch-jobs.mdbecausesearchJobsCommandsisn't in thecommandersmap incmd/src/doc.go. Fix belongs upstream.Verification
npx tsc --noEmitpassesnpx contentlayer buildgenerates 493 docs;cli/references/authandcli/references/codeownersnow resolve to theindex.mdxfilesdocs/orsrc/Follow-up (upstream)
To stop this recurring,
_generated.push.shshould mirrordocs/cli/references/(delete-then-copy) instead of copying over it. Done in sourcegraph/sourcegraph#15529 (merge after sourcegraph/sourcegraph#15528 and #1889).Amp threads