fix(#485): un-clip the room server URL + header scheme/band tidy - #487
Open
WilliamKarolDiCioccio wants to merge 2 commits into
Open
fix(#485): un-clip the room server URL + header scheme/band tidy#487WilliamKarolDiCioccio wants to merge 2 commits into
WilliamKarolDiCioccio wants to merge 2 commits into
Conversation
Collaborator
Author
|
FYI @runyaga |
WilliamKarolDiCioccio
changed the title
WilliamKarolDiCioccio
changed the title
The room header stacks the room name over the server it lives on. An AppBar's toolbar is a fixed kToolbarHeight (56px) box that silently clips an oversized title; with the tall brand font the two lines already fill it at the default text scale and overflow once the OS text size climbs past ~1.15x, clipping the server line's descenders — the artifact in the issue screenshot. It only reproduces with enlarged OS text (so not on a stock emulator), but the defect is ours: a fixed-height bar that can't fit its own content. - Grow the AppBar toolbarHeight to fit the measured two-line title at the current text scale, floored at kToolbarHeight so the leading/trailing icon buttons keep their Material touch-target size and the bar stays uncramped at the default scale. - Per Alan's suggestion, drop the `http(s)://` scheme and lead the server line with a link glyph that scales with the text; a human-readable server name (no scheme) passes through untouched. Shared stripUrlScheme helper added to server_entry.dart. Adds a regression test at 2.0x text scale asserting the toolbar grew past the fixed default and the server line sits inside it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Two small header tidies matching the room header pass: - Strip the `http(s)://` scheme from the selected server's name in the narrow AppBar title (via the shared stripUrlScheme helper), so it reads the same as the room header's server line. - Remove the in-pane server title band. The server is already named in the AppBar on narrow and in the always-visible sidebar on wide, so the band only repeated what was on screen. Drops the showServerHeading plumbing. The status banner is unchanged. Wide test now asserts the address shows once (sidebar only), no AppBar, no band. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
WilliamKarolDiCioccio
force-pushed
the
fix/room-header-server-url-clip-485
branch
from
July 31, 2026 16:02
437aaa6 to
75866e3
Compare
WilliamKarolDiCioccio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #485. Rebased onto current
main— trimmed to only what main doesn't already have.1. Room server URL clipped (#485)
An
AppBar's toolbar is a fixedkToolbarHeight(56px) box that silently clips an oversized title. With the tall brand font the two-line room title (name over server) fills 56px at default scale (~4px slack) and overflows once OS text size climbs past ~1.15×, clipping the server line's descenders — exactly the screenshot. Reproduces only with enlarged OS text (not on a stock emulator); the defect is a fixed-height bar that can't fit its own content.Fix: grow
AppBar.toolbarHeightto fit the measured two-line title at the current text scale, floored atkToolbarHeight. Per Alan's suggestion, drop the noisyhttp(s)://scheme and lead the server line with a text-scaling link glyph.2. Lobby header consistency
http(s)://scheme from the selected server's name in the narrow lobby AppBar (sharedstripUrlSchemehelper), so it reads the same as the room header.showServerHeadingplumbing main added. Status banner unchanged.Tests
flutter analyzeclean.Touches
room+lobbymodules and a sharedauth/server_entry.darthelper.🤖 Generated with Claude Code