Skip to content

[Tests] Update number of steps in regression step of ShewchukPCGLinearSolver.scn - #6205

Merged
fredroy merged 1 commit into
sofa-framework:masterfrom
alxbilger:shewchucksteps
Aug 6, 2026
Merged

[Tests] Update number of steps in regression step of ShewchukPCGLinearSolver.scn#6205
fredroy merged 1 commit into
sofa-framework:masterfrom
alxbilger:shewchucksteps

Conversation

@alxbilger

@alxbilger alxbilger commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Jul 24, 2026
@sofabot

sofabot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@alxbilger

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]

@sofabot

sofabot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@bakpaul

bakpaul commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Could you increase the number of step of the CG + decrease the tolerance ? Otherwise I'll have to do this again in my PR...

@sofabot

sofabot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@fredroy fredroy changed the title Update number of steps in regression step of ShewchukPCGLinearSolver.scn [Tests] Update number of steps in regression step of ShewchukPCGLinearSolver.scn Aug 6, 2026
@fredroy

fredroy commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy added the pr: fix Fix a bug label Aug 6, 2026
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 6, 2026
@fredroy
fredroy merged commit 10660f7 into sofa-framework:master Aug 6, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants