Expand Local tilde site paths for default macOS installs - #18
Open
nicolabiagioni wants to merge 1 commit into
Open
Expand Local tilde site paths for default macOS installs#18nicolabiagioni wants to merge 1 commit into
nicolabiagioni wants to merge 1 commit into
Conversation
Local stores ~/Local Sites/... in sites.json. Matching and WP-CLI --path used that string as a filesystem path, which broke auto-detect and the wrapper on stock Local setups. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sites.jsonstores site directories as~/Local Sites/<name>. The wrappers compared CWD and passed--pathagainst that string without expanding the tilde, so auto-detect failed and WP-CLI looked for a literal~/...folder.wp-pcp-local/setup-direnv) before matching or invoking WP-CLI.wp --listprints absolute paths, auto-detect from~/Local Sites/smand--site=smboth returnwp core version.Test plan
python3 skills/wp-cli-local/scripts/test_local_paths.pybash skills/wp-cli-local/scripts/wp --listshows expanded paths, not~/Local Sites/...bash skills/wp-cli-local/scripts/wp core versionauto-detectsbash skills/wp-cli-local/scripts/wp --site=<name> core versionworksnode scripts/build-agent-plugin.mjs --checkMade with Cursor