Conversation
Refactor unlock database logic to check for open dialogs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when
WindowCountwas "busy", the method did nothing at all — it neither opened a new dialog nor activated an existing one. The user saw "nothing happened", even though an unshown password entry dialog could actually be hanging somewhere behind the browser window. This patch adds an explicit attempt to bring the KeePass window to the foreground in that case — a minimal, safe change that does not affect the protocol or alter behavior whenWindowCount == 0.Related to #6 and #35