SK-3018 gitleaks fix - #336
Open
skyflow-bharti wants to merge 1 commit into
Open
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The security team's Gitleaks scan flagged 6 findings in skyflow-node — jwt and generic-api-key rule matches in Fern-auto-generated SDK files under src/ generated/rest/api/resources/. These are example JWTs and UUID-format token IDs embedded in @example doc-comment blocks (used to illustrate SDK usage in generated docs), not real credentials. Confirmed by decoding the flagged JWT, which resolves to the generic placeholder payload {"sub":"1234567890","name":"John Doe",...}.
Goal:
Suppress the 6 false-positive findings without touching the auto-generated source files (which would be overwritten on the next Fern codegen run anyway), using Gitleaks' native .gitleaksignore fingerprint suppression mechanism — consistent with the same fix applied in skyflow-react-native.