fix: bundle cryptography when oracledb is included in PyInstaller builds - #21
Merged
Merged
Conversation
oracledb's thin mode imports cryptography from thin_impl, a compiled Cython module PyInstaller cannot analyse, so the frozen binary failed at connection time with DPY-3016. Collect the package explicitly and abort the build when it is missing. Also fix binary detection in --onedir mode, where dist/db2sql is a directory.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 77 77
Lines 3076 3076
=======================================
Hits 2789 2789
Misses 287 287 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oracledb's thin mode imports cryptography from thin_impl, a compiled Cython module PyInstaller cannot analyse, so the frozen binary failed at connection time with DPY-3016. Collect the package explicitly and abort the build when it is missing. Also fix binary detection in --onedir mode, where dist/db2sql is a directory.