[Mage] Arcane 12.1 changes + set bonus#11527
Conversation
Lucasmingus
changed the title
|
|
||
| // Row 8 | ||
| player_talent_t touch_of_the_archmage_1; | ||
| player_talent_t prismatic_bolt_1; |
There was a problem hiding this comment.
Add a TODO somewhere on TotA so that we don't forget to remove it in 12.1.
| { | ||
| background = true; | ||
| aoe = -1; | ||
| radius = 8; |
There was a problem hiding this comment.
This should be automatically picked up from spell data
| // TODO: Remove check when 12.1 goes live -- in 12.1, pulse generates charges per enemy hit in impact() instead. | ||
| if ( p()->dbc->wowv() < wowv_t{ 12, 1, 0 } ) | ||
| { | ||
| p()->trigger_arcane_charge( as<int>( data().effectN( 2 ).base_value() ) ); |
There was a problem hiding this comment.
Better to generate the AC here with num_targets_hit (which is set after execute()). Saves some time by not having to do it one by one. Also, the Pulse echo behaves differently which isn't implemented here.
| // 12.1: Arcane Pulse now generates 1 arcane charge per enemy hit | ||
| // TODO: Remove check when 12.1 goes live | ||
| if ( p()->dbc->wowv() >= wowv_t{ 12, 1, 0 } && result_is_hit( s->result ) ) | ||
| p()->trigger_arcane_charge( 1 ); |
| } | ||
|
|
||
| // TODO: Remove check when 12.1 goes live | ||
| if ( p()->dbc->wowv() >= wowv_t{ 12, 1, 0 } ) |
There was a problem hiding this comment.
This check seems a bit meaningless? You're not getting cumulative power without already using 12.1 spell data
There was a problem hiding this comment.
right, maybe i went a bit overboard with the version checks
| { | ||
| custom_state_spell_t::execute(); | ||
|
|
||
| if ( p()->sets->has_set_bonus( MAGE_ARCANE, MID2, B4 ) ) |
There was a problem hiding this comment.
No need to check for this again if the buff is disabled (trigger chance == 0) without the tier set
2 participants
Arcane Pulse changes, Prismatic Bolt and 12.1 set bonus.
Added game version checks on everything related to Arcane Pulse changes.