Rename AlignmentStatistics variables to align* convention - #513
Merged
Conversation
Apply the Alignment module naming convention to all 30 variables in AlignmentStatistics: fields, accessors and @column names now carry the align prefix (e.g. shareCohabitingSim -> alignPartnerSimShare). CSV columns are sorted alphabetically by field name, so the headers in AlignmentStatistics.csv are both renamed and reordered; the expected integration-test file is updated to match, with values unchanged.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes AlignmentStatistics naming to the Alignment module’s align* convention by renaming all relevant fields/getters/setters and aligning the JPA @Column names accordingly, so downstream exports (notably AlignmentStatistics.csv) reflect the updated naming scheme.
Changes:
- Renamed AlignmentStatistics variables (fields + accessors) to
align*names (e.g., partnership/fertility/in-school/util adjustment/employment share measures). - Updated JPA
@Columnnames to match the newalign_*naming convention. - Updated the expected
AlignmentStatistics.csvheaders (renamed + reordered) to match the new exported column names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/simpaths/data/statistics/AlignmentStatistics.java | Renames alignment statistics fields/accessors and updates @Column names; updates update() to use the new setters. |
| src/test/java/simpaths/integrationtest/expected/AlignmentStatistics.csv | Updates expected CSV header names/order to match the renamed AlignmentStatistics fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the Alignment module naming convention to all 30 variables in
AlignmentStatistics: fields, accessors and @column names now carry the
align prefix (e.g. shareCohabitingSim -> alignPartnerSimShare).
CSV columns are sorted alphabetically by field name, so the headers in
AlignmentStatistics.csv are both renamed and reordered; the expected
integration-test file is updated to match, with values unchanged.