migrate: pre-validate --stop-before targets across all sets before applying - #871
Open
webdevsamran wants to merge 1 commit into
Open
webdevsamran wants to merge 1 commit into
webdevsamran wants to merge 1 commit into
Conversation
…plying When sqlite-utils migrate is invoked with multiple migration sets, an already-applied --stop-before target in a subsequent set would cause an error inside that set's apply() call only after earlier sets had already executed and committed their pending migrations. Pre-validate across all loaded migration sets upfront that no requested --stop-before targets have already been applied before entering the application loop, ensuring no pending migrations are applied when an error is raised. Fixes simonw#870 Signed-off-by: Samran Asif <samranwebdev2000@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running
sqlite-utils migratewith multiple migration sets, an already-applied--stop-beforetarget in a subsequent set would raise an error insideMigrations.apply()only after earlier sets had already applied and committed their pending migrations.This violates the documented contract for
--stop-before:Fixes #870
Solution
In
sqlite_utils/cli.py(migratecommand), after validating unknown--stop-beforemigration names, pre-validate across all loaded migration sets upfront that no requested targets have already been applied in the database.If any matching target is already applied, a
ClickExceptionis raised before entering the execution loop, ensuring that no migrations in earlier sets are executed or committed.Testing
test_stop_before_applied_migration_multiple_sets_does_not_apply_earlierintests/test_cli_migrate.py.aremains uncreated and onlyb:firstis recorded in_sqlite_migrations.flake8andblack.Assisted by AI (Google DeepMind / Antigravity). Researched, verified, and authored with human review.
📚 Documentation preview 📚: https://sqlite-utils--871.org.readthedocs.build/en/871/