fix: replace assert with UpdateError in Table.update() method - #867
Closed
KooshaPari wants to merge 1 commit into
Closed
KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Table.update()used a bareassert rowcount == 1statement to validate the update affected exactly one row. This has two problems:assertstatements are stripped when Python runs in optimized mode (python -O), silently disabling the checkAssertionError) is not informativeThe code had a TODO comment acknowledging this:
# TODO: Test this works (rolls back) - use better exceptionFix
assert rowcount == 1with an explicit check that raises a newUpdateErrorexception with a descriptive messageUpdateErrorexception class tosqlite_utils/db.pyTesting
test_update_error_class_existsto verify the exception class workstest_update.pypass📚 Documentation preview 📚: https://sqlite-utils--867.org.readthedocs.build/en/867/