fix: add transaction guard to vacuum() method (fixes #479) - #862
Closed
KooshaPari wants to merge 1 commit into
Closed
KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #479
Changes
_ensure_no_open_transactionandensure_autocommit_onguards toDatabase.vacuum(), matching the pattern used byenable_wal()anddisable_wal()TransactionErrorwith a descriptive message instead of a crypticOperationalError: cannot VACUUM from within a transactionTesting
test_vacuum_raises_transaction_error_inside_atomicto verify TransactionError is raisedtest_vacuum_works_outside_atomicto verify normal operation still workstest_atomic.pypass📚 Documentation preview 📚: https://sqlite-utils--862.org.readthedocs.build/en/862/