SF-3931 Show draft running or failed in the menu - #4127
Open
pmachapman wants to merge 3 commits into
Open
pmachapman wants to merge 3 commits into
pmachapman wants to merge 3 commits into
Conversation
pmachapman
added
the
will require testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4127 +/- ##
==========================================
+ Coverage 80.94% 80.96% +0.01%
==========================================
Files 664 664
Lines 42182 42224 +42
Branches 6951 6955 +4
==========================================
+ Hits 34146 34188 +42
Misses 6870 6870
Partials 1166 1166 ☔ View full report in Codecov by Harness. |
Contributor
|
📸 Screenshot diff deployed! (2 changes) View the visual diff at: https://pr-4127--sf-screenshot-diffs.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the draft generation menu item act like the sync menu item by showing that a draft is in progress, or showing that a draft has failed.
The draft generating animation looks like:
(it is SVG so can be tweaked however you like)
This change is