Skip to content

Fix http-proxy patch for PNPM 12.x - #4126

Open
pmachapman wants to merge 1 commit into
masterfrom
fix/http-proxy-patch
Open

pmachapman wants to merge 1 commit into
masterfrom
fix/http-proxy-patch

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes an error I was encountering when attempting to run docker compose build on my PC:

45.41   Progress: resolved 1802, reused 606, downloaded 1189, added 1802, done
45.44   .../node_modules/@swc/core postinstall$ node postinstall.js
45.51   .../node_modules/@swc/core postinstall: Done
51.75 EXEC : error : ERR_PNPM_INVALID_PATCH [/src/SIL.XForge.Scripture/SIL.XForge.Scripture.csproj]
51.75
51.75     × installing dependencies
51.75     ╰─▶ Applying patch "/src/SIL.XForge.Scripture/ClientApp/patches/http-
51.75         proxy@1.18.1.patch" failed: error parsing patches: error parsing patch:
51.75         invalid char in unquoted filename
51.75
51.83 /src/SIL.XForge.Scripture/SIL.XForge.Scripture.csproj(169,5): error MSB3073: The command "pnpm install" exited with code 1.
51.84
51.84 Build FAILED.

I fixed the issue by running:

pnpm patch http-proxy@1.18.1

Patching the files, then running:

pnpm patch-commit "D:\Source\Repos\web-xforge\src\SIL.XForge.Scripture\ClientApp\node_modules\.pnpm_patches\http-proxy@1.18.1"

This change is Reviewable

@pmachapman pmachapman changed the title Fix http-proxy path for PNPM 12.x Fix http-proxy patch for PNPM 12.x Sep 20, 2026
@pmachapman
pmachapman deployed to screenshot_diff September 20, 2026 22:47 — with GitHub Actions Active
@codecov

codecov Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.94%. Comparing base (3f221d3) to head (ace6e12).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4126   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         664      664           
  Lines       42182    42182           
  Branches     6951     6945    -6     
=======================================
  Hits        34146    34146           
  Misses       6870     6870           
  Partials     1166     1166           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant