e2e: improve --help info - #4110
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4110 +/- ##
=======================================
Coverage 80.94% 80.94%
=======================================
Files 664 664
Lines 42182 42182
Branches 6951 6951
=======================================
Hits 34146 34146
- Misses 6870 6885 +15
+ Partials 1166 1151 -15 ☔ View full report in Codecov by Harness. |
| [ | ||
| 'Usage: ./characterize-tests.mts [preset]', | ||
| '', | ||
| 'Runs tests repeatedly to characterize flakyness. Individual tests cannot be selected.', |
There was a problem hiding this comment.
Individual tests cannot be selected
What you're supposed to do is update test_characterization.json (e.g. by setting numbers to 0 after making changes to a test), and then running this.
So "Individual tests cannot be selected." feels to me like it's declining to state how this is supposed to be used, and instead just telling you how not to use it. If you use it correctly, do end up specifying which tests need to be characterized.
b6c6b7b to
08f817a
Compare
marksvc
left a comment
marksvc
left a comment
There was a problem hiding this comment.
@marksvc made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on Nateowami).
| [ | ||
| 'Usage: ./characterize-tests.mts [preset]', | ||
| '', | ||
| 'Runs tests repeatedly to characterize flakyness. Individual tests cannot be selected.', |
|
✅ No screenshot differences — all stories are identical. View the diff page at: https://pr-4110--sf-screenshot-diffs.netlify.app |
Nateowami
left a comment
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami reviewed 3 files, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on marksvc).
73f252d to
3b8ed0a
Compare
2 participants
Open in Devin Review
This change is