Prompt for the device button during device claim - #15
Merged
Merged
Conversation
The server now holds the claim request until the button is pressed or a minute passes, so the command prompts for the press and waits on the one request with its own longer client timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device claimnow printsPress the button on the device to finish claiming it.after validation and waits on the one request while the server holds it up to a minute: a 90 s client for this call replaces the shared 30 s one. The 204 output and error handling are unchanged.Evidence:
CGO_ENABLED=0build, vet, and test; the stdout-asserting table covers the prompt plus claimed line and the button-not-pressed error;gofmt -lclean;go mod tidyclean.Needs the paired server deployed first. Against the current production server the prompt prints and the claim still completes immediately.