OpAMP thread dump - use custom message - #2984
Conversation
# Conflicts: # opamp/src/main/java/com/splunk/opentelemetry/opamp/OpampActivator.java # opamp/src/test/java/com/splunk/opentelemetry/opamp/OpampActivatorTest.java
|
I like this solution much more than the previous one! Good change. |
| public static final String HACKY_CMD_CAPABILITY = "com.splunk.opamp.experimental_command/v1"; | ||
| public static final String HACKY_CMD_TYPE = "command"; |
There was a problem hiding this comment.
so the current idea is to set the type to command command and get the actual command from the message body, did you consider having separate types for different commands e.g. thread-dump?
There was a problem hiding this comment.
rename these fields
I think you're asking me to hide my shame. 🙈
so the current idea is to set the type to command command and get the actual command from the message body, did you consider having separate types for different commands e.g. thread-dump?
I did consider it, and @robsunday also pointed out something similar. I'm not sure that this will be around for long, or if it's even a good idea, so I thought it would be marginally better to keep it contained within one type. If we did want to promote commands up to type then we would probably want to consider a namespace so that all commands aren't in some flat hierarchy....but now it's already over-engineered.
If you feel strongly about this we can change it. I certainly don't have a strong preference.
There was a problem hiding this comment.
I was thinking that this way the consumer of the message wouldn't need to parse the message body to know it is a thread dump which might make it easier to handle.
3 participants
Switch from using hacky remote config to using the also hacky custom message.