Validate Keyper configurations before broadcasting add-keyper-set transactions - #11
Open
novenrizkia856-ui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds validation to the
AddKeyperSetworkflow so invalid Keyper configurations are rejected before any onchain transactions are broadcast.The validation mirrors the invariants required by the current Rolling Shutter configuration semantics and avoids introducing legacy or speculative restrictions.
Changes
Validate Keyper configuration before
vm.startBroadcast(...).Reject:
threshold == 0;Preserve the existing
activationDelta >= 1validation.Keep valid non-majority thresholds supported, e.g.
1-of-3.Apply the same behavior to the gnosh variant of the script.
Add regression tests covering invalid configurations and boundary-valid cases.
Rationale
The add-Keyper-set script previously only checked whether the threshold exceeded the number of Keypers, and configuration parsing/validation happened after broadcasting had started.
This change moves deterministic configuration validation to the script boundary so malformed configurations fail before inappropriate onchain operations can be sent.
No majority-threshold requirement or other legacy Keyper constraints are introduced unless required by the current implementation.
Closes #8