Add OWNERS, CODEOWNERS, and ansible-lint GitHub Action for Prow onboarding#18
Open
imatza-rh wants to merge 3 commits into
Open
Add OWNERS, CODEOWNERS, and ansible-lint GitHub Action for Prow onboarding#18imatza-rh wants to merge 3 commits into
imatza-rh wants to merge 3 commits into
Conversation
Onboard shiftstack-qa to Prow by adding OWNERS and OWNERS_ALIASES files (team list from shiftstack-ci). Add GitHub Actions workflow to run ansible-lint on PRs using the shiftstack-client container, providing a status check for Tide to gate on. Ref: OSPRH-32049 Change-Id: I2da24ec05257777d61600a1623bafe6a5670ced3 Signed-off-by: Itay Matza <imatza@redhat.com>
Add ANSIBLE_VAULT_PASSWORD_FILE env var to the GitHub Action so ansible-lint can parse vault-encrypted secret.yaml. Add missing changed_when: true to two tasks in get_openshift_release_binaries.yml that modify state (extract pull secret, extract OCP tools) to fix no-changed-when violations. Ref: OSPRH-32049 Change-Id: Id34425370a73e003b0fa1160105713ed8691c6cd Signed-off-by: Itay Matza <imatza@redhat.com>
Update OWNERS_ALIASES with the full shiftstack engineering team. Add CODEOWNERS for automatic reviewer assignment on PRs. Ref: OSPRH-32049 Change-Id: I76ab049af712bab5fdc40ff6dbd6b264e704e18f Signed-off-by: Itay Matza <imatza@redhat.com>
imatza-rh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Prow-based PR review workflow (/lgtm, /approve, /hold) and add GitHub Actions ansible-lint CI check.
Changes
.github/workflows/ansible-lint.yml: GitHub Action running ansible-lint on PRs using the shiftstack-client container (same asgate.sh)changed_when: trueto two tasks inget_openshift_release_binaries.ymland set vault password for CINext steps (separate PRs)
core-services/prow/02_config/shiftstack/shiftstack-qa/Ref: OSPRH-32049