Harden repo workflow and modernize runtime verification - #1
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b8477d55a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| needs_ingestion = True | ||
|
|
||
| if needs_ingestion: | ||
| count = await rag_engine.ingest_document(rules_pdf_path) |
There was a problem hiding this comment.
bootstrap_backend checks collection state in the caller-supplied chroma_path, but on ingestion it delegates to rag_engine.ingest_document(...), which writes via a module-level collection initialized against ./chroma_db (gov_agent/rag_engine.py), not the passed path. In any non-default run (e.g., temp/test DB), this leaves the requested collection empty and causes bootstrap to re-ingest on every run while data is written to a different store.
Useful? React with 👍 / 👎.
| return <>{children}</>; | ||
| } | ||
|
|
||
| const isLoggedIn = typeof window !== 'undefined' && !!localStorage.getItem('govbot_token'); |
There was a problem hiding this comment.
Computing isLoggedIn directly from localStorage during render creates an SSR/client hydration mismatch: server-rendered output is always logged-out, but hydrated client output may be logged-in for users with a stored token. This can cause visible nav flicker and hydration warnings on first paint; the prior effect-driven state initialization avoided that mismatch.
Useful? React with 👍 / 👎.
1 participant
Summary
Makefile, CI, env templates, and canonical contributor/agent docsgoogle-genai, and add graceful RAG fallback behaviorTest Plan
pytest -qmake bootstrapmake check/,/services,/pmkisan,/form-fill,/renewals,/track-search, and/documentslogin redirect