dockerignore: re-include harness/**/*.tmpl so the integration-harness image builds - #566
Conversation
… image builds Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
PR SummaryLow Risk Overview .dockerignore drops the obsolete CI adds a non-push Build integration-harness image step alongside controller and sidecar, so future Reviewed by Cursor Bugbot for commit 67865be. Bugbot is set up for automated code reviews on this repo. Configure here. |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Adds Non-blocking
1 nit, not posted on the code
seidroid review · decision Findings: 0 blocking | 1 non-blocking | 0 posted inline |
…ation tmpl re-include Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Summary
Every
mainECR run's "Build and push integration-harness image" step has failed since #558 withpattern seiload_job.yaml.tmpl: no matching files found(the controller and sidecar images publish fine, so runs show red but the controller image the platform bump needs is pushed).#558 moved the
//go:embed-ed fault and seiload templates out oftest/integration/into the importableharness/faultsandharness/benchpackages, but.dockerignoreignores everything by default and only re-includedtest/integration/**/*.tmpl. The integration suite imports both harness packages, so thego test -c -tags integrationbuild intest/integration/Dockerfilecouldn't find the embeds..dockerignore: add!harness/**/*.tmpl; drop the now-dead!test/integration/**/*.tmpl(no.tmplremains there). Inert in the controller/sidecar build contexts (neither compilesharness/).ci.ymldockerjob: add a third no-push build oftest/integration/Dockerfile, so a build-context gap for the harness image fails the PR instead of the firstmainpublish run (the job's existing rationale, which previously only covered the other two images).Verified locally:
docker build -f test/integration/Dockerfile .succeeds on this branch.Link to Devin session: https://app.devin.ai/sessions/810d9802ec224aeba508275645d3aee2
Open in Devin Desktop: https://app.devin.ai/desktop/session/810d9802ec224aeba508275645d3aee2?variant=devin
Requested by: @bdchatham