Remove console rule exception from ESLint config - #603
Merged
Conversation
The src/bin and src/lib override disabling no-console was a TODO placeholder for a logger wrapper. No console calls remain in those directories, so drop the override and let no-console apply globally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SvMcZS3PArzNFjDS4qPs37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the ESLint configuration override that previously disabled the
no-consolerule for files insrc/bin/**/*.tsandsrc/lib/**/*.ts.Summary
The exception that allowed console calls in bin and lib source files has been removed. This means the
no-consolerule will now be enforced across all TypeScript files, including those in the bin and lib directories.Changes
no-consoleforsrc/bin/**/*.tsandsrc/lib/**/*.tsfilesNotes
This change enforces stricter linting rules across the codebase. Any existing console calls in the affected directories will now trigger ESLint errors and will need to be addressed (either by implementing a logger wrapper as previously noted, or by removing the console calls).
https://claude.ai/code/session_01SvMcZS3PArzNFjDS4qPs37