Refactor: Convert snake_case variables to camelCase throughout codebase - #600
Merged
Merged
Conversation
The `camelcase` ESLint rule was disabled for `src/bin` and `src/lib`
because local identifiers mirrored the snake_case parameter names of the
Seam API. Rename those identifiers and drop the override.
Where a name is only a local binding, it is renamed outright. Where the
name also has to leave the process, the snake_case key is kept and only
the binding is renamed:
- `seam.accessCodes.list({ device_id })`, `seam.acs.users.list({
acs_system_id })` and `seam.actionAttempts.get({ action_attempt_id })`
keep their request keys.
- `interactForAccessCode` keeps `device_id` as its destructuring key,
since callers pass the blueprint params bag through as `args.params as
any` and the cast hides a mismatch from the type checker.
- The `use_remote_api_defs` config key stays snake_case so existing
installs keep reading their stored setting.
- `getOutput().data({ action_attempt })` keeps its output key.
The three `prompt()` answer keys are internal to a single function each,
so their `name` and binding are renamed together.
`no-console` stays off; its TODO is unrelated.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017BkuFhVWgKzWQYTDpz4w9Y
razor-x
force-pushed
the
claude/camelcase-eslint-removal-plan-eeznkm
branch
from
August 4, 2026 19:12
e75109b to
ded34dc
Compare
razor-x
marked this pull request as ready for review
August 4, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors variable naming conventions across the codebase to use camelCase instead of snake_case, improving code consistency and enabling the camelcase ESLint rule.
Key Changes
custom_metadata→customMetadata,action_attempt→actionAttempt,should_auto_submit→shouldAutoSubmitaction_attempt→actionAttempt,connect_webview→connectWebviewpoll_for_action_attempt→pollForActionAttempt,custom_key_to_remove→customKeyToRemovecamelcase: 'off'rule from eslint.config.ts, enabling camelCase enforcementinteract-for-access-code.tsexplaining that thedevice_idparameter key must remain snake_case to match Seam API specifications, while the local binding uses camelCaseNotable Implementation Details
device_id,action_attempt_id) to maintain compatibility with the APIhttps://claude.ai/code/session_017BkuFhVWgKzWQYTDpz4w9Y