Skip to content

Update HMA PerformanceAlert to be an error - #2929

Merged
frances-h merged 4 commits into
mainfrom
issue-2918-hma-performance-error
Jul 28, 2026
Merged

Update HMA PerformanceAlert to be an error#2929
frances-h merged 4 commits into
mainfrom
issue-2918-hma-performance-error

Conversation

@frances-h

Copy link
Copy Markdown
Contributor

Resolve #2918

After discussion, we decided to simplify the error condition to any schema with more than five tables or a depth greater than 2.

@frances-h frances-h self-assigned this Jul 21, 2026
@frances-h
frances-h requested a review from a team as a code owner July 21, 2026 14:54
@frances-h
frances-h requested review from amontanez24 and removed request for a team July 21, 2026 14:54
@frances-h
frances-h force-pushed the issue-2918-hma-performance-error branch 2 times, most recently from e3ffe63 to 8355e35 Compare July 21, 2026 15:06
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.06%. Comparing base (8b11933) to head (a90b8a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2929   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          75       75           
  Lines        8587     8589    +2     
=======================================
+ Hits         8421     8423    +2     
  Misses        166      166           
Flag Coverage Δ
integration 76.48% <100.00%> (+<0.01%) ⬆️
unit 97.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread sdv/multi_table/hma.py Outdated
Comment thread tests/integration/multi_table/test_hma.py
@frances-h
frances-h force-pushed the issue-2918-hma-performance-error branch from 9399566 to 5088eec Compare July 23, 2026 20:21
@frances-h
frances-h force-pushed the issue-2918-hma-performance-error branch from 5088eec to a90b8a5 Compare July 27, 2026 14:27
@frances-h
frances-h merged commit 43310d3 into main Jul 28, 2026
47 checks passed
@frances-h
frances-h deleted the issue-2918-hma-performance-error branch July 28, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update HMA PerformanceAlert to be an error

3 participants