Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 85.81% 86.86% +1.05%
==========================================
Files 40 41 +1
Lines 3722 4409 +687
==========================================
+ Hits 3194 3830 +636
- Misses 528 579 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
R-Palazzo
left a comment
There was a problem hiding this comment.
This is looking good!
Do we expect this PR to support running TabDDPMSynthesizer in the single-table benchmark, including running it on AWS and GCP?
If so, could we add integration tests for benchmark_single_table()?
For AWS and GCP, I previously tested this manually and shared the result folder in the PR. For example, for #549, this is the test folder
I can help for testing it on AWS and GCP
amontanez24
left a comment
There was a problem hiding this comment.
We're expecting that they will never update their library right? That is why we're moving all the code into here?
Yes exactly, the last update made to the repo was 3 years ago. It's unmaintained code that if we'd like to benchmark then we should copy over the code. |
|
Results of the benchmark test are provided in this folder @R-Palazzo @amontanez24 |
original implementation is https://github.com/yandex-research/tab-ddpm/tree/main/tab_ddpm