QtFRED fix waypoint initial orders - #7664
Open
MjnMixael wants to merge 1 commit into
Open
Conversation
New initial orders start with no committed target (_object == -1). The target combo visually defaults to its first item, but with signals blocked that selection is never pushed to the model, and re-picking the already-shown item emits no change signal. Ship/player targets auto-commit their first valid entry inline during population; waypoint paths, individual waypoints, ship classes, and wings did not, so a new order of those types stayed uncommitted and failed validation on apply. Add a uniform fallback after the target combos are populated: if a new order has no committed target, commit the currently-shown default. No-op for ships (already committed) and existing orders (loaded with a target already set).
wookieejedi
approved these changes
Jul 29, 2026
github-project-automation
Bot
moved this from Work In Progress (PRs)
to In Review (PRs)
in qtFRED2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New initial orders start with no committed target (_object == -1). The target combo visually defaults to its first item, but with signals blocked that selection is never pushed to the model, and re-picking the already-shown item emits no change signal. Ship/player targets auto-commit their first valid entry inline during population; waypoint paths, individual waypoints, ship classes, and wings did not, so a new order of those types stayed uncommitted and failed validation on apply.
Add a uniform fallback after the target combos are populated. If a new order has no committed target, commit the currently-shown default.