Skip to content

Use MPI.Comm as type annotation in main functions #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
finsberg wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

Use MPI.Comm as type annotation in main functions #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
641fc56
Use MPI.Comm as type annotation in main functions
finsberg Aug 31, 2026
f27c4b2
Merge remote-tracking branch 'origin/main' into mpi-comm-type-fix
finsberg Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/adding_backend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ You should import these to type-hint your implementation correctly:

## Implementation Checklist

Your backend module must implement the functions listed below. Note that `comm` is always an {py:class}`MPI.Intracomm<mpi4py.MPI.Intracomm>` and `filename` is a
Your backend module must implement the functions listed below. Note that `comm` is always an {py:class}`MPI.Comm<mpi4py.MPI.Comm>` and `filename` is a
{py:class}`pathlib.Path` or {py:class}`str`.

### General Configuration
Expand Down Expand Up @@ -96,7 +96,7 @@ def get_default_backend_args(arguments: dict[str, Any] | None) -> dict[str, Any]

def write_mesh(
filename: Path | str,
comm: MPI.Intracomm,
comm: MPI.Comm,
mesh: MeshData,
backend_args: dict[str, Any] | None,
mode: FileMode,
Expand Down
10 changes: 5 additions & 5 deletions src/io4dolfinx/checkpointing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@

def write_attributes(
filename: Path | str,
comm: MPI.Intracomm,
comm: MPI.Comm,
name: str,
attributes: dict[str, np.ndarray],
backend_args: dict[str, typing.Any] | None = None,
Expand All @@ -82,7 +82,7 @@ def write_attributes(

def read_attributes(
filename: Path | str,
comm: MPI.Intracomm,
comm: MPI.Comm,
name: str,
backend_args: dict[str, typing.Any] | None = None,
backend: str | None = None,
Expand All @@ -107,7 +107,7 @@ def read_attributes(

def read_timestamps(
filename: Path | str,
comm: MPI.Intracomm,
comm: MPI.Comm,
function_name: str,
backend_args: dict[str, typing.Any] | None = None,
backend: str | None = None,
Expand Down Expand Up @@ -403,7 +403,7 @@ def read_function(

def read_mesh(
filename: Path | str,
comm: MPI.Intracomm,
comm: MPI.Comm,
ghost_mode: dolfinx.mesh.GhostMode = dolfinx.mesh.GhostMode.shared_facet,
time: float | str | None = 0.0,
read_from_partition: bool = False,
Expand Down Expand Up @@ -630,7 +630,7 @@ def write_function(

def read_function_names(
filename: Path | str,
comm: MPI.Intracomm,
comm: MPI.Comm,
backend_args: dict[str, Any] | None = None,
backend: str = "h5py",
) -> list[str]:
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def _read_function_time_dep(
def _generate_reference_map(
mesh: dolfinx.mesh.Mesh,
meshtag: dolfinx.mesh.MeshTags,
comm: MPI.Intracomm,
comm: MPI.Comm,
root: int,
) -> typing.Optional[dict[str, tuple[int, npt.NDArray]]]:
"""
Expand Down