Skip to content

Less strict tolerance in hessian convergence test #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finsberg merged 2 commits into from
Sep 3, 2026
Merged

Less strict tolerance in hessian convergence test #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd8300b
Less strict tolerance in heessian convergence test
finsberg Sep 3, 2026
6b0003b
Use fancy fixture from Jørgen
finsberg Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions tests/test_interpolate_nonmatching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from dolfinx_adjoint import Function, assemble_scalar, interpolate_nonmatching


def _run_adjoint_and_taylor_test(mesh_from, mesh_to, use_petsc):
def _run_adjoint_and_taylor_test(mesh_from, mesh_to, use_petsc, assert_hessian_matches_finite_difference):
"""Helper function to test Adjoint symmetry and Taylor convergence."""
pyadjoint.get_working_tape().clear_tape()

Expand Down Expand Up @@ -80,26 +80,22 @@ def _run_adjoint_and_taylor_test(mesh_from, mesh_to, use_petsc):
assert np.isclose(min_rate, 2.0, rtol=1e-2, atol=1e-2)

# Hessian check: expect rate = 3.0 (Linear operator Hessian is 0, so Taylor series is exact)
Jh(u)
dJdm = Jh.derivative()._ad_dot(du)
dHddu = Jh.hessian(du)._ad_dot(du)
min_rate_hess = pyadjoint.taylor_test(Jh, u, du, dJdm=dJdm, Hm=dHddu)
assert np.isclose(min_rate_hess, 3.0, rtol=1e-3, atol=1e-3)
assert_hessian_matches_finite_difference(Jh, u, du)


@pytest.mark.parametrize("use_petsc", [False, True])
def test_nonmatching_3D_to_2D(use_petsc):
def test_nonmatching_3D_to_2D(use_petsc, assert_hessian_matches_finite_difference):
"""Tests interpolating from a 3D volume to a 2D surface."""
mesh_from = create_unit_cube(MPI.COMM_WORLD, 4, 4, 4)
mesh_to = create_unit_square(MPI.COMM_WORLD, 8, 8)

_run_adjoint_and_taylor_test(mesh_from, mesh_to, use_petsc)
_run_adjoint_and_taylor_test(mesh_from, mesh_to, use_petsc, assert_hessian_matches_finite_difference)


@pytest.mark.parametrize("use_petsc", [False, True])
def test_nonmatching_2D_to_2D(use_petsc):
def test_nonmatching_2D_to_2D(use_petsc, assert_hessian_matches_finite_difference):
"""Tests interpolating from a 2D surface to a 2D surface."""
mesh_from = create_unit_square(MPI.COMM_WORLD, 8, 8)
mesh_to = create_unit_square(MPI.COMM_WORLD, 4, 4)

_run_adjoint_and_taylor_test(mesh_from, mesh_to, use_petsc)
_run_adjoint_and_taylor_test(mesh_from, mesh_to, use_petsc, assert_hessian_matches_finite_difference)