CLDSRV-955: Cache node_modules instead of yarn download cache#6227
Conversation
Hello tcarmet,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.3 #6227 +/- ##
===================================================
+ Coverage 84.93% 84.96% +0.02%
===================================================
Files 206 206
Lines 13366 13366
===================================================
+ Hits 11353 11356 +3
+ Misses 2013 2010 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Replace `cache: yarn` (which only caches the yarn download dir) with an actions/cache on node_modules keyed by the yarn.lock hash, and make the yarn install / typescript steps conditional on a cache miss. Because the git dependencies compile TypeScript at install time, a warm cache now skips the clone, tsc build and relink entirely. Applied to the setup-ci composite action (used by all functional jobs) and the lint, async-migration-report, unit-tests and cleanup-gcp-buckets jobs.
The prettier check formats whole changed files; touching action.yaml brought its pre-existing double-quoted name/description into scope. Reformat them to single quotes to match the prettier style.
tcarmet
force-pushed
the
improvement/CLDSRV-955/node-modules-cache
branch
from
8b6ef65 to
b9c4715
Compare
|
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
Build failedThe build for commit did not succeed in branch improvement/CLDSRV-955/node-modules-cache The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue CLDSRV-955. Goodbye tcarmet. The following options are set: approve |
5 participants
Speeds up CI by caching the installed dependency tree between runs instead of only the package-manager download cache. Because several dependencies compile TypeScript at install time, previous runs re-cloned, recompiled and relinked them on every job despite a "cache hit"; now a warm cache skips that work entirely and jobs reuse the prior install.
Measured impact (warm run vs a development/9.3 baseline)
lintunit-testsfile-ft-testssetup-cicomposite action).${{ runner.os }}-node-modules-${{ hashFiles('yarn.lock') }}; a lockfile bump invalidates it and the next run repopulates.See the pinned comparison comment for full details.