Skip to content

test: fix flaky agent create NUT (Bot User race) #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nico-pappagianis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: fix flaky agent create NUT (Bot User race) #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions test/nuts/z0.agent.create.nut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
*/

import { join } from 'node:path';
import { readdirSync, statSync } from 'node:fs';
import { appendFileSync, readdirSync, statSync } from 'node:fs';
import { expect } from 'chai';
import { genUniqueString, TestSession } from '@salesforce/cli-plugins-testkit';
import { execCmd } from '@salesforce/cli-plugins-testkit';
import type { AgentCreateSpecResult } from '../../src/commands/agent/generate/agent-spec.js';
import type { AgentCreateResult } from '../../src/commands/agent/create.js';
import { getTestSession, getUsername } from './shared-setup.js';
import { getAgentUsername, getTestSession, getUsername } from './shared-setup.js';

/* eslint-disable no-console */

Expand Down Expand Up @@ -68,6 +68,18 @@ describe('agent create', function () {
const expectedFilePath = join(session.project.dir, 'specs', specFileName);
const name = 'Plugin Agent Test';
const apiName = 'Plugin_Agent_Test';

// Reuse the Bot User pre-provisioned in shared setup (via `org create agent-user`) instead of
// letting core auto-create one during the save. The 'customer' agentType maps to core's
// EinsteinServiceAgent, which requires a licensed Bot User; when no user is supplied, core creates
// that user in the SAME transaction as the BotDefinition save, and the pre-save validation trigger
// intermittently cannot see the just-created license/permset assignment, failing with "User
// doesn't have access to agent." `agent create` sets agentSettings.userId from the spec's
// `agentUser`, so writing the already-committed agent user into the spec removes that race.
const agentUser = getAgentUsername();
expect(agentUser, 'agent user should have been provisioned in shared setup').to.be.a('string');
appendFileSync(expectedFilePath, `\nagentUser: "${agentUser!}"\n`);

const command = `agent create --spec ${expectedFilePath} --target-org ${username} --name "${name}" --api-name ${apiName} --json`;
const result = execCmd<AgentCreateResult>(command, { ensureExitCode: 0 }).jsonOutput?.result;
expect(result).to.be.ok;
Expand Down
Loading