Skip to content

Harden install.sh replacement with atomic staging#876

Merged
ryanfowler merged 1 commit into
mainfrom
fix-atomic-installer-replace
Jul 17, 2026
Merged

Harden install.sh replacement with atomic staging#876
ryanfowler merged 1 commit into
mainfrom
fix-atomic-installer-replace

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Stage the downloaded binary on the destination filesystem, validate it, and replace the target with a single atomic rename
  • Allow overriding the install directory with FETCH_INSTALL_DIR
  • Add installer integration tests for replacement, cleanup, and directory/symlink edge cases
  • Update CI and contributor guidance to include the install test suite

Testing

  • Added integration coverage for atomic replacement and cleanup behavior in tests/install.rs
  • Not run (not requested)

@ryanfowler
ryanfowler enabled auto-merge July 17, 2026 00:09
@ryanfowler
ryanfowler merged commit afc6c4b into main Jul 17, 2026
4 checks passed
@ryanfowler
ryanfowler deleted the fix-atomic-installer-replace branch July 17, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant