Update to libssh2 master branch - #362
Merged
Merged
Conversation
Member
Author
|
CI fails, I don't have the time to investigate this right now, but we should do this IMO. |
Member
|
|
Member
Author
|
Needs more work on passing tests. |
The diffie-hellman-group* KEX methods were removed from the default list in OpenSSH 10.0 and disabled by default since libssh2 1.11.1. Elliptic curve methods have been supported in the default list for 14 years now according to the OpenSSH change log, so it should be safe to choose this for tests.
MD5 hashes have been disabled by default by libssh2 1.11.1.
Collaborator
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We temporarily pointed it to my fork with some uplifted patches. We shouldn't do that long term, we should instead use libssh2 upstream and update regularly to get fixes.