Conversation
libyaml's `yaml_*_event_initialize()` functions reject an anchor, tag, or value that is not valid UTF-8 (and can fail on allocation errors), returning 0 and leaving the passed `yaml_event_t` untouched. The emitter ignored that return value and emitted the event anyway. It may cause unexpected behavior. For example, `yaml_emitter_emit()` may touch an invalid address or double free an invalid event. We can avoid it by checking every `yaml_*_event_initialize()` call and raise instead of emitting a stale or uninitialized event.
kou
force-pushed
the
emitter-check-event-initialize
branch
from
September 21, 2026 14:51
4bda41c to
769ddd9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libyaml's
yaml_*_event_initialize()functions reject an anchor, tag, or value that is not valid UTF-8 (and can fail on allocation errors), returning 0 and leaving the passedyaml_event_tuntouched.The emitter ignored that return value and emitted the event anyway. It may cause unexpected behavior. For example,
yaml_emitter_emit()may touch an invalid address or double free an invalid event.We can avoid it by checking every
yaml_*_event_initialize()call and raise instead of emitting a stale or uninitialized event.