Accept a nested target as the first for loop index#4156
Open
shugo wants to merge 1 commit into
Open
Conversation
A `for` loop index may be a multiple-assignment target whose first
element is itself a parenthesized (nested) target, e.g.
for (a, b), c in 1..10
end
CRuby's parse.y accepts this, and a plain multiple assignment with the
same target (`(a, b), c = ...`) is accepted, but Prism rejected it with
"unexpected write target".
When parse_parentheses finishes the first `(a, b)`, it validates the
multi-target it produced. In a `for` index it only allowed the target
to be followed by `in`, so a following `,` (which continues the index
target list) fell through to the "not a statement level" error. Allow
a comma there as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
forloop index may be a multiple-assignment target whose first element is itself a parenthesized (nested) target, e.g.CRuby's parse.y accepts this, and a plain multiple assignment with the same target (
(a, b), c = ...) is accepted, but Prism rejected it with "unexpected write target".When parse_parentheses finishes the first
(a, b), it validates the multi-target it produced. In aforindex it only allowed the target to be followed byin, so a following,(which continues the index target list) fell through to the "not a statement level" error. Allow a comma there as well.