Skip to content

Single commit --> patch is not annotated with PR header? #33

Description

@larsxschneider

I just created a PR with one commit:
git/git#237

SubmitGit shows me the PR message in the UI but resulting email looks like this:

From: Lars Schneider <larsxschneider@gmail.com>

Also change UK english "behaviour" to US english "behavior".

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>

---
Documentation/SubmittingPatches | 80 ++++++++++++++++++++++++++++++++---------
1 file changed, 63 insertions(+), 17 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 98fc4cc..60e0e55 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches

...

------------------------------------------------
MUA specific hints


--
This is a preview - if you want to send this message for real, click here:
https://submitgit.herokuapp.com/git/git/pull/237/db2ee5760c9f5d54393ecaf70aec23bda5c6f410/e0c97993e3f89869d26e7eec04567edf9c06b400

I would expect:

From: Lars Schneider <larsxschneider@gmail.com>

Also change UK english "behaviour" to US english "behavior".

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>

---

diff to v1:

remind the reader to check documentation set formatting
do not call Travis CI as "our infrastructure"
do not make it sound as we want to make everyone a GitHub customer
move detailed Travis CI instructions to a separate section (I thought about a separate file but I think there is not enough content at this point to justify it)
Thanks Junio, Stefan, and Matthieu for the review,
Lars

Documentation/SubmittingPatches | 80 ++++++++++++++++++++++++++++++++---------
1 file changed, 63 insertions(+), 17 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 98fc4cc..60e0e55 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches

...

------------------------------------------------
MUA specific hints


--
This is a preview - if you want to send this message for real, click here:
https://submitgit.herokuapp.com/git/git/pull/237/db2ee5760c9f5d54393ecaf70aec23bda5c6f410/e0c97993e3f89869d26e7eec04567edf9c06b400

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions