fix: Handles multiple cookie headers correctly according to rfc6265 - #440
Merged
Merged
Conversation
|
|
The third sub-test had no expectation, so the non-Cookie comma separator was never actually verified. Capture req$HEADERS and assert on it, and add a case where two Cookie headers are separated by another header and differ in case. Also add a NEWS entry.
schloerke
enabled auto-merge (squash)
September 21, 2026 17:15
Collaborator
|
Thank you, @andyquinterom ! |
Collaborator
|
@andyquinterom Great chatting with you IRL at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLM-5 helped to build the Unit test.