Conversation
1 task
chhtz
reviewed
Sep 17, 2026
chhtz
left a comment
Member
There was a problem hiding this comment.
LGTM. I guess we didn't hit this, because it is not used during import or build-phase. (N.B., we still check out syskit@master, which appears to be stale ...)
Nevertheless, there are still calls to constant left in other files, e.g.
- and line 56
tools-syskit/lib/syskit/gui/testing.rb
Line 222 in 9097fc7
tools-syskit/lib/syskit/scripts/browse.rb
Line 45 in 9097fc7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.